You are viewing a single comment's thread from:

RE: Reply directly from notifications! by STEEM ULTIMATE EDITOR

Hi! This is a nice project you've got here. I'm glad utopian allowed me to discover it.

Let's go for the review.
Honestly I don't have much to say, you've produced code of great quality. But to say little things nonetheless.

  • https://github.com/tngflx/Steem-UltimateEditor/blob/master/src/js/notify/notifications.js#L38 => You've got a few empty lines, a nice way to be sure to get rid of those is to add prettier on your project.

  • https://github.com/tngflx/Steem-UltimateEditor/blob/master/src/js/notify/notifications.js#L38 => Any particular reason why you're mixing old notation with arrow functions ?

  • Your comments are well used and it's great! Your project is a good example of how other contributions should use them.

  • You could improve your README.md by adding more information, more examples like in your steemit posts or add links to those posts.

  • The only down side to your project I see and I think it's a huge one is that users have to install an xamp server and host the files. People are lazy you should try to find a way for them to use your project in a matter of clicks or minutes. How would feel if you had to install and host your own gmail for example?

In any case keep up the good work!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

Contributing on Utopian
Learn how to contribute on our website.

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Wow this is the first time I get such high rating from review :D I'm so glad my hard work paid off. Yeah on that xampp I will find a way. Thanks for such high review from you!

Coin Marketplace

STEEM 0.19
TRX 0.03
JST 0.027
TRX 0.03
STEEM 0.19
JST 0.027
SBD 3.34